Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow @type be of type array #103

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: allow @type be of type array #103

wants to merge 1 commit into from

Conversation

simontaurus
Copy link
Contributor

@simontaurus simontaurus commented Nov 21, 2024 •
edited
Loading

@simontaurus simontaurus mentioned this pull request Nov 21, 2024
Merged
@SteffenBrinckmann
Copy link
Collaborator

@simontaurus Great for preparing the example.
@type and may: while the .eln follows every must specification of the ro-crate, the situation is different for the may statements. the ro-crate specification has a lot of them and each of them results in multiple algorithms and if-statements for the import. Hence, the ELN consortium tries to harmonize the may-statements into must-according-to-.eln. Hence, .eln becomes a variant of ro-crate with its own rules.
And the type issue, is just one of them. We agreed, also in the Nov. 2024 meeting, that type is a string of dataset, ... ;and that any further type like information is stored in the 'genre' key.

@simontaurus simontaurus mentioned this pull request Nov 22, 2024
Closed
@simontaurus
Copy link
Contributor Author

simontaurus commented Nov 22, 2024 •
edited
Loading

Moved for further discussion here #69

PS: Would be happy to join the Consortium & next Consortium meeting

simontaurus added a commit to OpenSemanticLab/TheELNFileFormat that referenced this pull request Nov 22, 2024
@simontaurus
fix: move internal types to schema:additionalType
52bd430 
Refs: TheELNConsortium#103, TheELNConsortium#69
@NicolasCARPi
Copy link
Contributor

Would be happy to join the Consortium

Invited.

Should we close this PR then?

NicolasCARPi pushed a commit that referenced this pull request Nov 26, 2024
@simontaurus
add minimal osl example eln file (#104)
ef8d64e 
* add minimal osl example eln file

* fix: move internal types to schema:additionalType

Refs: #103, #69

* docs: add README.md for OpenSemanticLab example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simontaurus @SteffenBrinckmann @NicolasCARPi